Review Request 59449: KYLIN-2637 The tips is not shown after creating project successfully.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Review Request 59449: KYLIN-2637 The tips is not shown after creating project successfully.

pengjianhua

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59449/
-----------------------------------------------------------

Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Bugs: KYLIN-2637
    https://issues.apache.org/jira/browse/KYLIN-2637


Repository: kylin


Description
-------

The following code in page.js:
   SweetAlert.swal('Success!', 'New project created successfully!', 'success');
   $modalInstance.dismiss('cancel');
   $cookieStore.put("project", newProj.name);
   location.reload();

'SweetAlert' is invoked before 'location.reload()', so it cannot be shown.


Diffs
-----

  webapp/app/js/controllers/page.js 056cc488f


Diff: https://reviews.apache.org/r/59449/diff/1/


Testing
-------


Thanks,

pengjianhua

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Review Request 59449: KYLIN-2637 The tips is not shown after creating project successfully.

pengjianhua

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59449/
-----------------------------------------------------------

(Updated 五月 22, 2017, 12:32 p.m.)


Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Bugs: KYLIN-2637
    https://issues.apache.org/jira/browse/KYLIN-2637


Repository: kylin


Description
-------

The following code in page.js:
   SweetAlert.swal('Success!', 'New project created successfully!', 'success');
   $modalInstance.dismiss('cancel');
   $cookieStore.put("project", newProj.name);
   location.reload();

'SweetAlert' is invoked before 'location.reload()', so it cannot be shown.


Diffs (updated)
-----

  webapp/app/js/controllers/page.js 056cc488f


Diff: https://reviews.apache.org/r/59449/diff/2/

Changes: https://reviews.apache.org/r/59449/diff/1-2/


Testing
-------


Thanks,

pengjianhua

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Review Request 59449: KYLIN-2637 The tips is not shown after creating project successfully.

pengjianhua

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59449/
-----------------------------------------------------------

(Updated 五月 22, 2017, 12:35 p.m.)


Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Bugs: KYLIN-2637
    https://issues.apache.org/jira/browse/KYLIN-2637


Repository: kylin


Description
-------

The following code in page.js:
   SweetAlert.swal('Success!', 'New project created successfully!', 'success');
   $modalInstance.dismiss('cancel');
   $cookieStore.put("project", newProj.name);
   location.reload();

'SweetAlert' is invoked before 'location.reload()', so it cannot be shown.


Diffs (updated)
-----

  webapp/app/js/controllers/page.js 056cc488f


Diff: https://reviews.apache.org/r/59449/diff/3/

Changes: https://reviews.apache.org/r/59449/diff/2-3/


Testing
-------


Thanks,

pengjianhua

Loading...